-
Notifications
You must be signed in to change notification settings - Fork 158
Expose ObjectCode
as public API + prune unnecessary input arguments
#435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/ok to test |
/ok to test |
/ok to test |
ObjectCode
as public API + prune unnecessary input arguments
|
I think we should invest the time to change the design so that ObjectCode only represents cubins, but I think this change can be standalone thanks to the comment about not passing anything but a cubin when directly constructing an ObjectCode. My thought for ptx / ltoir / other IRs is that we add two things: Program.code -> returns the code string (for user and needed by linker ) Linker will need some modifications. Something like: Linker.add_code_object becomes Linker.add_program() - this is to pass IR program |
9f6496f
to
87c1571
Compare
We discussed the above comment in an offline meeting. Capturing some thoughts:
FWIW I think adding @vzhurba01 since both Keenan and I already touched this PR significantly, please kindly review it. |
/ok to test |
Small test update needed but all else looks good to me |
Co-authored-by: Vladislav Zhurba <[email protected]>
/ok to test |
CI is green! |
close #194
close #448
close #450