[cuda_pathfinder] Initial version of find_nvidia_headers.py for nvshmem (Minimal Viable Product)
#661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
leofang
added
P0
|
Just wondering what is the status for this PR? |
leofang
added
cuda.pathfinder
|
I still need to fix this up, after merging #723 a couple days ago. |
leofang
modified the milestones:
cuda-pathfinder first release,
cuda-pathfinder parking lot
|
Is there some mechanism so that user can override the path returned by the api? Or that's largely a library duty to maintain? |
1 task
…modernize new code
…more complete commands for setting up manual testing.
rwgk
changed the title
path_finder find_nvidia_headers.py (Minimal Viable Product)find_nvidia_headers.py for nvshmem (Minimal Viable Product)
|
/ok to test |
|
Will it tolerate |
The code added in this PR ignores those completely. I've only tested these situations (copy-pasted from the current Offline @leofang wrote that getting headers in general is now the top priority (I just created #832 to track the work). That will bring in Coming back to |
From offline with nvshmem team: if installed via apt package they go to |
Oh, @isVoid Is there another way people usually install |
This aligns with my local testing as well. Sorry about the confusion! To support the python use case, we are only requesting the library to be discoverable when it's installed via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently no public API.
To support internal developments.