Fix command line arguments for linker and compiler #895
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g, and lineinfo. Fix ProgramOptions.__repr__() to return a string instead of a list.
|
/ok to test |
@mmason-nvidia, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
mdboom
reviewed
Aug 22, 2025
leofang
reviewed
Aug 22, 2025
| @@ -244,8 +244,8 @@ def __post_init__(self): | |||
| self._formatted_options.append("--device-debug") | |||
| if self.lineinfo is not None and self.lineinfo: | |||
| self._formatted_options.append("--generate-line-info") | |||
| if self.device_code_optimize is not None: | |||
| self._formatted_options.append(f"--dopt={'on' if self.device_code_optimize else 'off'}") | |||
| if self.device_code_optimize is not None and self.device_code_optimize: | |||
There was a problem hiding this comment.
Suggested change
| if self.device_code_optimize is not None and self.device_code_optimize: | |
| if self.device_code_optimize is True: |
| self.formatted_options.append("-g") | ||
| if self.lineinfo is not None: | ||
| if self.lineinfo is not None and self.lineinfo: |
There was a problem hiding this comment.
Suggested change
| if self.lineinfo is not None and self.lineinfo: | |
| if self.lineinfo is True: |
| self.formatted_options.append("-lto") | ||
| if self.ptx is not None: | ||
| self.formatted_options.append("-ptx") | ||
| if self.optimization_level is not None: | ||
| self.formatted_options.append(f"-O{self.optimization_level}") | ||
| if self.debug is not None: | ||
| if self.debug is not None and self.debug: |
There was a problem hiding this comment.
Suggested change
| if self.debug is not None and self.debug: | |
| if self.debug is True: |
| @@ -205,15 +205,15 @@ def _init_nvjitlink(self): | |||
| self.formatted_options.append("-time") | |||
| if self.verbose is not None: | |||
| self.formatted_options.append("-verbose") | |||
| if self.link_time_optimization is not None: | |||
| if self.link_time_optimization is not None and self.link_time_optimization: | |||
There was a problem hiding this comment.
Suggested change
| if self.link_time_optimization is not None and self.link_time_optimization: | |
| if self.link_time_optimization is True: |
Probably a good idea! |
leofang
added
enhancement
leofang
approved these changes
Aug 22, 2025
|
/ok to test 9f1282f |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix command line arguments checking related to optimization, debugging, and lineinfo.
Fix ProgramOptions.repr() to return a string instead of a list.
Checklist