Add support for building ubuntu22.04 on amd64 #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. In ubuntu22.04 header file "rpc.h" is no longer stored in "/rpc"
directory. So we use flag WITH_TIRPC to succesfully build.
2. In ubuntu22.04 docker image we install "libeld-dev" package so we
don`t need to build the library. That is why we use WITH_LIBELF
flag.
Signed-off-by: Dmitrii Chervov <[email protected]>
|
@elezar can you please check my PR? |
elezar
reviewed
Apr 17, 2025
|
|
||
| # Supported OSs by architecture | ||
| AMD64_TARGETS := ubuntu20.04 ubuntu18.04 ubuntu16.04 debian10 debian9 | ||
| AMD64_TARGETS := ubuntu22.04 ubuntu20.04 ubuntu18.04 ubuntu16.04 debian10 debian9 |
There was a problem hiding this comment.
Same comment as on NVIDIA/nvidia-container-toolkit#1004
Do we want to add arm64 builds here too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual build for libnvidia-container is necessary! It can help open source community with debug and adding new features to this magnificent library!
Manual build correct working was tested by me on ubuntu22.04 (run docker with gpus all on different models).