Require matching version of libnvidia-container-tools #1100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
pin-libnvidia-container-tools-version
branch
from
c6eeac3 to
badc228
Compare
Since the nvidia-container-tools and libnvidia-container* packages are now released at the same time with the same version, a more restrictive version makes sense. Here we specifically require an equal version for the nvidia-container-toolkit* packages and the libnvidia-container* packages. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
pin-libnvidia-container-tools-version
branch
from
badc228 to
d5cc484
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the nvidia-container-tools and libnvidia-container* packages are now released at the same time with the same version, a more restrictive version makes sense. Here we specifically require an equal version for the nvidia-container-toolkit* packages and the libnvidia-container* packages.
For this to function properly the changes from NVIDIA/libnvidia-container#317 are also required and the following should also be noted:
dnfis able to properly resolve the dependencies and install all packages with a matching version.aptis not able to resolve the dependencies properly and that means that if newer versions of dependencies (i.e. thelibnvidia-container-toolsandlibnvidia-container1packages) are available an error will be shown if these are not explicitly pinned.See #1091