Skip to content

Require matching version of libnvidia-container-tools #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elezar
Copy link
Member

@elezar elezar commented May 22, 2025

Since the nvidia-container-tools and libnvidia-container* packages are now released at the same time with the same version, a more restrictive version makes sense. Here we specifically require an equal version for the nvidia-container-toolkit* packages and the libnvidia-container* packages.

For this to function properly the changes from NVIDIA/libnvidia-container#317 are also required and the following should also be noted:

  • On rpm-based systems dnf is able to properly resolve the dependencies and install all packages with a matching version.
  • On deb-based systems apt is not able to resolve the dependencies properly and that means that if newer versions of dependencies (i.e. the libnvidia-container-tools and libnvidia-container1 packages) are available an error will be shown if these are not explicitly pinned.

See #1091

@elezar elezar force-pushed the pin-libnvidia-container-tools-version branch from c6eeac3 to badc228 Compare May 22, 2025 09:05
Since the nvidia-container-tools and libnvidia-container* packages
are now released at the same time with the same version, a more
restrictive version makes sense. Here we specifically require an
equal version for the nvidia-container-toolkit* packages and the
libnvidia-container* packages.

Signed-off-by: Evan Lezar <[email protected]>
@elezar elezar force-pushed the pin-libnvidia-container-tools-version branch from badc228 to d5cc484 Compare May 22, 2025 10:03
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Draft

Copy link

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this!

@elezar elezar self-assigned this May 27, 2025
@elezar elezar requested a review from klueska May 27, 2025 12:27
@elezar elezar added this to the v1.18.0 milestone May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants