Skip to content
This repository was archived by the owner on Oct 18, 2024. It is now read-only.

Send log event to menubar IPC #29

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

JamesHemery
Copy link
Contributor

No description provided.

@simonhamp
Copy link
Member

I'm not sure what this PR is aiming to achieve... can you give some context?

@JamesHemery
Copy link
Contributor Author

Currently the menubar render process does not receive logs because it is not part of state.windows.

@simonhamp
Copy link
Member

@JamesHemery can you explain a little more about what this is going to allow you do?

@JamesHemery
Copy link
Contributor Author

@simonhamp My app uses the logs to run some effects. On the other hand, I think it's more consistent to send the logs to the menu bar as well.

@simonhamp
Copy link
Member

I'm going to allow this because in theory it doesn't hurt.

But I'm not sure about your use-case. I feel like whatever you're trying to achieve needs to be done another way 😅

@simonhamp simonhamp merged commit a0a1766 into NativePHP:main Jul 18, 2024
@JamesHemery JamesHemery deleted the feature/menu-bar-log-debug branch September 2, 2024 08:37
@JamesHemery
Copy link
Contributor Author

JamesHemery commented Sep 2, 2024

@simonhamp Thx ! In my case this allows to cancel the need for Reverb / Laravel websocket in the simplest cases.

NativePHP/laravel#295 (comment)

This method, defined here as a temporary fix, is, I think, a perfectly suitable method for the simplest use cases.

On the other hand, it makes sense to send logs to all app windows for consistency :)

@simonhamp
Copy link
Member

Agreed with the consistency issue. I have a feeling that this won't work in a production build as the LogWatcher is meant as a way to support debugging during development...

Have you tested a production build yet?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants