Skip to content

feat: adds the required config for using GitHub as an updater provider #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

danjohnson95
Copy link
Contributor

Adds config to the nativephp.php config file for configuring GitHub as an updater provider.

This is required with my PR here - NativePHP/electron#75

@mpociot
Copy link
Member

mpociot commented Sep 21, 2023

That's great, thank you!
Could you also add all the environment files to the config, which should automatically be removed when bundling the app?

https://github.com/NativePHP/laravel/blob/main/config/nativephp.php#L46-L54

I'm pretty sure all of these can be removed, as they are not needed in the actual PHP application when it's bundled to be used within NativePHP. Otherwise users will accidentally leak their GitHub token

@mpociot mpociot merged commit a1e38b5 into NativePHP:main Sep 21, 2023
@mpociot
Copy link
Member

mpociot commented Sep 21, 2023

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants