Fix migrations when database does not exist

[miagg]

My previous PR #408 fixed native:migrate:fresh but only when database already existed. 😢
When database is missing, it does not migrate at all.

It seems that the Artisan::call is not needed at all during the database creation since the parent handler will migrate the database anyway.

Please check if I'm right before merging. It did solve the problem for me but I wouldn't want to break something.

Sorry for the confusion.

[simonhamp]

When database is missing, it does not migrate at all.

That makes sense to me - it can't migrate a database that doesn't exist

Does Laravel's own migrate:fresh create the database?

the parent handler will migrate the database anyway

Which parent handler?

[miagg]

Which parent handler?

@simonhamp, The DB is migrated after the rewriteDatabase() call on both commands. It seems totally unneeded here. Also, this call will migrate the original database and not the appdata database. Maybe @mpociot can confirm this. I'm not familiar with the codebase, I just wanted to pinpoint the error and the solution that worked for me instead of openning an issue.

laravel/src/Commands/FreshCommand.php

Line 22 in cee53d7

return parent::handle();

laravel/src/Commands/MigrateCommand.php

Line 25 in cee53d7

return parent::handle();

[simonhamp]

Thanks for that extra context. You're right that it's potentially unnecessary - in the context of running the commands - but from what I can tell it shouldn't cause any issues with those - the parent::handle() attempt would be a no-op ("Nothing to migrate").

It is still needed when the developer boots the app without running native:migrate.

this call will migrate the original database and not the appdata database

We're not concerned about that here. The appdata database gets migrated automatically when the NATIVEPHP_APP_VERSION changes.

When database is missing, it (native:migrate:fresh) does not migrate at all.

Does Laravel's migrate:fresh create a database when it doesn't exist?

Although the code for Laravel's FreshCommand itself seems to suggest that it could create the database, if the database file that it's trying to set up doesn't exist in the first place, it errors:

I think this is probably the correct behaviour. In any case, this would be something to take up with the Laravel project.

So I don't think we need to change anything here on our side.

---

If you wanted to, you could remove the unnecessary (and potentially recursive) logic that executes when running the migration commands, I think it's a case of moving these lines out of rewriteDatabase and into their own method in the NativeServiceProvider that only gets executed when APP_DEBUG=true:

if (! file_exists($databasePath)) {
    touch($databasePath);

    Artisan::call('native:migrate');
}

On second thoughts, don't attempt this. It's not that straightforward.

[simonhamp]

I've tested this thoroughly now - and created #413 off the back of that.

So I'm confident that this is all working as intended and that this PR isn't necessary.

Thanks