Skip to content

fix: $iniSettings on ChildProcess.php #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2025
Merged

fix: $iniSettings on ChildProcess.php #535

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61edc8a
fix: $iniSettings on ChildProcess.php
SRWieZ Mar 31, 2025
729a370
fix: ensure properties are set only if they exist
SRWieZ Mar 31, 2025
2c26e6e
fix: throw exception for non-existent properties in ChildProcess
SRWieZ Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/ChildProcess.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ class ChildProcess implements ChildProcessContract

public readonly bool $persistent;

public readonly ?array $iniSettings;

final public function __construct(protected Client $client) {}

public function get(?string $alias = null): ?self
Expand Down Expand Up @@ -147,6 +149,10 @@ protected function fromRuntimeProcess($process)
}

foreach ($process['settings'] as $key => $value) {
if (! property_exists($this, $key)) {
throw new \RuntimeException("Property {$key} does not exist on ".__CLASS__);
}

$this->{$key} = $value;
}

Expand Down
Loading