Plamen5kov/require spike #587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the new require logic follows the node require specification problems occur when we try to load nested node_modules structure without flattening
|
💔 |
|
run ci |
|
💔 |
The module resolution logic handles better the case when one tries to load module from outside the app folder.
|
💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of this require specification.
Our
tns-core-modulesare the equivalent of core modules in this implementation of require to keep functionality.It's expected for the build to fail, until NativeScript/nativescript-cli#2136 is merged.
ping: @NativeScript/android-runtime