Optimize package size. Native Android plugins need to declare usage of v8 symbols explicitly in package.json now. #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 |
build two versions of the runtime - regular, and optimized
petekanev
force-pushed
the
optimize-size
branch
from
6be867d to
7e62c65
Compare
|
💔 |
|
run CI |
|
💚 |
petekanev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on work previously done in #522 , this PR aims to build and distribute a reduced in size runtime package when a project dependency does not explicitly state that it consumes API exposed by the JavaScript engine (V8)
The optimizations come mostly from stripping the V8 symbol table, and account for about 3MB reduction in package size, combined, when all 3 supported android architectures are packed.
The optimized android runtime package will be used by default on android projects unless a dependency (nativescript plugin) has the
useV8symbols: truekey (subject to approval) inside their package.json's nativescript object, in which case the regular runtime distribution will be packed with the APK.Depends on NativeScript/nativescript-cli#2138
Addresses #529
@NativeScript/android-runtime