[firebase-database] Unsubscribe to event still doesn't work

[danouche93]

After opening 2 tickets #109 #120, the method "off()" to unsubscribe from event still isn't working.

[triniwiz]

Hey @danouche93 I added a test for this lmk if that works for you.

[danouche93]

Thank you @triniwiz
I finally found what was the problem. When I called the off() function, I was re-creating a ref to the database path like firebase().database().ref(path), so by doing that it wasn't unsubscribing from the event because it didn't have the right ref.
To fix it, I had to save the ref path to an array so that I could access it to unsubscribe from the event like so :

listenerWrappers: any[] = [];
EventListener(onValueEvent: any, path: string): any {
    var ref = firebase().database().ref(path);
    const listener = ref.on('value', onValueEvent);
    this.listenerWrappers.push({ listener: listener, path: path, ref: ref });
  }

RemoveListeners(path: string) {
    var listenerWrapper = this.listenerWrappers.filter(l => l.path == path)[0];
    if (listenerWrapper) {
      listenerWrapper.ref.off('value', listenerWrapper.listener)
      this.listenerWrappers.splice(this.listenerWrappers.indexOf(listenerWrapper), 1);
    }
  }

I hope it will help people that had the same issue !