chore: cleanup onSnapshot implementations #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, lovely improvement 🤩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I had mainly written this refactor to address bugs that were probably addressed in ba384c2 and c74f67a, I still believe this is worth submitting as the current onSnapshot handler implementations are very difficult to understand due to parameter names and overloads. This refactor aims to address the issue of parsing the parameters (with full type checking) centrally in a single
parseOnSnapshotArgshelper, after which we can implement the actual handling logic in a way that looks much more intuitive in the individual onSnapshot methods.