Skip to content

fix(messaging): Activity registerForActivityResult is not a function #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2022
Merged

fix(messaging): Activity registerForActivityResult is not a function #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions packages/firebase-messaging-core/index.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,18 +58,23 @@ let _permissionQueue: { resolve: Function; reject: Function }[] = [];

function register(args: any) {
if (!lastActivity) {
lastActivity = new WeakRef(args.activity);
requestPermissionLauncher = args.activity.registerForActivityResult(
new androidx.activity.result.contract.ActivityResultContracts.RequestPermission(),
new androidx.activity.result.ActivityResultCallback({
onActivityResult(isGranted: boolean) {
_permissionQueue.forEach((callback) => {
callback.resolve(isGranted ? 0 : 1);
});
_permissionQueue.splice(0);
},
})
);
// Some activities do not implement activity result API
if (args.activity.registerForActivityResult) {
lastActivity = new WeakRef(args.activity);
requestPermissionLauncher = args.activity.registerForActivityResult(
new androidx.activity.result.contract.ActivityResultContracts.RequestPermission(),
new androidx.activity.result.ActivityResultCallback({
onActivityResult(isGranted: boolean) {
_permissionQueue.forEach((callback) => {
callback.resolve(isGranted ? 0 : 1);
});
_permissionQueue.splice(0);
},
})
);
} else {
Application.android.once('activityCreated', register);
}
}
}

Expand Down