Skip to content

feat(dynamic-links): forward errors to application #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mukaschultze
Copy link
Contributor

This PR adds an optional parameter to the onLink handler that indicates the error that occurred while fetching the target of a short dynamic link.

There are two reasons for this change:

  • This makes both iOS and Android behave the same for unknown links. Right now the Android handler emits null for unknown links, while iOS simply ignores them.
  • The error is useful for applications that need to show some sort of user message or dispatch an event upon malformed or unknown dynamic links.

BREAKING CHANGE: This change will call the dynamic link handler with null values on iOS. For Android, it'll be the same as before since the error param is optional.

@cla-bot cla-bot bot added the cla: yes label Jan 24, 2023
@triniwiz triniwiz merged commit a50026e into NativeScript:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants