fix(dynamic-links): IllegalArgumentException on resolveLink #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

triniwiz merged 1 commit into NativeScript:main from mukaschultze:fix/remove-wrong-line-dynamic-links

Feb 9, 2023

Contributor

mukaschultze commented Feb 4, 2023

This PR fixes the following error when calling resolveLink on android:

Error: java.lang.IllegalArgumentException: FDL domain is missing. Set with setDomainUriPrefix() or setDynamicLinkDomain().

I imagine that the buildShortDynamicLink is either a leftover from older code or was pasted by accident in that method implementation.


          fix: remove buildShortDynamicLink call

cla-bot bot added the cla: yes label

triniwiz merged commit 85c3a4f into NativeScript:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels