fix(runtime): Respect availability attributes for protocols and base classes #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbektchiev
force-pushed
the
bektchiev/respect-availability-attributes-for-protocols
branch
from
ae18b38 to
3ec5a02
Compare
|
test package_version#latest |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
mbektchiev
force-pushed
the
bektchiev/respect-availability-attributes-for-protocols
branch
from
3ec5a02 to
4bdbdfa
Compare
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
mbektchiev
force-pushed
the
bektchiev/respect-availability-attributes-for-protocols
branch
2 times, most recently
from
d2e119e to
8b81914
Compare
* Add `isImplementedInClass` and `isAvailableInClass` methods in `PropertyMeta` and `MethodMeta` which additionally check whether a Class instance supports a given optional method * Use `isAvailableInClass` instead of `isAvailable` in `getOwnPropertyNames` of `ObjCPrototype`, `ObjCConstructorBase`, `ObjCConstructorNative` and in `materializeProperties` of `ObjCConstructorNative` * Filter via `isAvailableInClass` in `BaseClassMeta`'s various method and property getters * Change `MembersCollection` to be a `HashSet` to avoid adding the same member more than once when collecting them from the inheritance chain * Remove unused functions from `BaseClassMeta` * Add `findInterfaceMeta` function with fallback to the base interface if the desired one is unavailable in the current SDK version (instead of the hardcoded `NSObject` so far) * Remove hacky patch from `ObjCMethodWrapper::preInvocation` which fixed the symptoms of #978 but not its root cause. Namely, that unimplemented optional methods were returned as available properties in `getOwnPropertyNames`. * Modify fixtures and add test cases for methods availability in `InheritanceTests.js` * Add test case for unavailable base class * Add test case for property with custom selector in ApiTests. The getter of `secureTextEntry`(`isSecureText`) overrides the default `secureTextEntry` * Add `encodeVersion` `getMajorVersion` and `getMinorVersion` helpers refs #1085
Apple regularly create new protocols and move existing interface members there. E.g. iOS 12.0 introduced the UIFocusItemScrollableContainer protocol in UIKit which contained members that have existed in UIScrollView since iOS 2.0. * Create `findProtocol` function in `GlobalTable` * Use it instead of `findMeta` everwhere where a protocol is looked for * Add tests refs #1084
mbektchiev
force-pushed
the
bektchiev/respect-availability-attributes-for-protocols
branch
from
8b81914 to
5bfffab
Compare
* Ensure that the module providing the method is loaded before checking * Add check for dynamic selectors * As a last resort `alloc` an instance and send `respondsToSelector` message * Cache each class' instances to minimize the number of allocations and deallocations performed * Improve diagnostics messages in the `ApiIterator` test
Do not break the loop at the first encountered unavailable initializer
* Add not implemented initializers * Check that implemented initializers will be called * Check that not implemented initializers will not be used
If we don't have this special treatment we enter an endless recursion.
darind
approved these changes
Mar 5, 2019
* Remove redundant `static_cast`
ghost
removed
the
mbektchiev
deleted the
bektchiev/respect-availability-attributes-for-protocols
branch
mbektchiev
added a commit
that referenced
this pull request
Mar 11, 2019
Fix issue with missing `imageInsets`, `landscapeImagePhone`, `title` properties of UITabBarItem. These properties are declared in `UIBarItem` but it actually doesn't implement them. Some of its successors like `UITabBarItem` however do, and we need to expose them there. This regression has been introduced with #1086.
5 tasks
mbektchiev
added a commit
that referenced
this pull request
Mar 12, 2019
Fix issue with missing `imageInsets`, `landscapeImagePhone`, `title` properties of UITabBarItem. These properties are declared in `UIBarItem` but it actually doesn't implement them. Some of its successors like `UITabBarItem` however do, and we need to expose them there. This regression has been introduced with #1086.
mbektchiev
added a commit
that referenced
this pull request
Mar 12, 2019
Fix issue with missing `imageInsets`, `landscapeImagePhone`, `title` properties of UITabBarItem. These properties are declared in `UIBarItem` but it actually doesn't implement them. Some of its successors like `UITabBarItem` however do, and we need to expose them there. This regression has been introduced with #1086.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Filter members which are unavailable in the current SDK
Add
isImplementedInClassandisAvailableInClassmethods inPropertyMetaandMethodMetawhich additionally check whether a Classinstance supports a given optional method
Use
isAvailableInClassinstead ofisAvailableingetOwnPropertyNamesof
ObjCPrototype,ObjCConstructorBase,ObjCConstructorNativeandin
materializePropertiesofObjCConstructorNativeFilter via
isAvailableInClassinBaseClassMeta's variousmethod and property getters
Change
MembersCollectionto be aHashSetto avoid adding the samemember more than once when collecting them from the inheritance chain
Remove unused functions from
BaseClassMetaAdd
findInterfaceMetafunction with fallback to the base interfaceif the desired one is unavailable in the current SDK version (instead
of the hardcoded
NSObjectso far)Remove hacky patch from
ObjCMethodWrapper::preInvocationwhichfixed the symptoms of Reading collisionBoundingPath on UIView results in Objective C exception #978 but not its root cause. Namely, that
unimplemented optional methods were returned as available properties
in
getOwnPropertyNames.Modify fixtures and add test cases for methods availability in
InheritanceTests.jsAdd test case for unavailable base class
Add test case for property with custom selector in ApiTests. The getter
of
secureTextEntry(isSecureText) overrides the defaultsecureTextEntryAdd
encodeVersiongetMajorVersionandgetMinorVersionhelpersNever check for availability of protocols
Apple regularly create new protocols and move existing
interface members there. E.g. iOS 12.0 introduced the
UIFocusItemScrollableContainer protocol in UIKit which
contained members that have existed in UIScrollView
since iOS 2.0.
findProtocolfunction inGlobalTablefindMetaeverwhere where a protocol is looked forrefs #1084, #1085