fix(inspector): Fix API compatibility issue with Inspector #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with High Sierra some internal APIs used by our version of WebKit are not present. We resort to the dynamic libraries built into the OS instead of using our own until we upgrade to the latest WebKit.
mbektchiev
changed the title
tdermendjiev
approved these changes
Dec 14, 2017
|
run ci |
dtopuzov
approved these changes
Dec 15, 2017
mbektchiev
approved these changes
Dec 15, 2017
|
How to update to this version 3.4.0 ? |
|
@abdul-elah-js - you can simply use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are internal APIs used by our WebKit build that are not present on High Sierra. We need to use the builtin WebCore frameworks to avoid crashing instead of our own. This fix checks if we are on High Sierra and resorts to the builtin frameworks if yes. We need this up until we upgrade to the latest WebKit version which does not use the internal APIs.