fix(simulator): Boot orphan simulator #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
suggested changes
Feb 16, 2018
lib/iphone-simulator-xcode-simctl.ts
Outdated
| @@ -238,6 +244,15 @@ export class XCodeSimctlSimulator extends IPhoneSimulatorNameGetter implements I | |||
| } | |||
| } | |||
|
|
|||
| private isSimulatorAppRunning() { | |||
There was a problem hiding this comment.
this method needs a return type
lib/iphone-simulator-xcode-simctl.ts
Outdated
| @@ -238,6 +244,15 @@ export class XCodeSimctlSimulator extends IPhoneSimulatorNameGetter implements I | |||
| } | |||
| } | |||
|
|
|||
| private isSimulatorAppRunning() { | |||
| try { | |||
| const output = childProcess.execSync("ps cax | grep -w Simulator"); | |||
There was a problem hiding this comment.
you can extract the Simulator in a const:
const simulatorAppName = "Simulator";
const output = childProcess.execSync(`ps cax | grep -w ${simulatorAppName}`);
return output.indexOf(simulatorAppName) !== -1;
Fatme
force-pushed
the
fatme/fix-orphan-simulator
branch
from
68fe898 to
919e80a
Compare
rosen-vladimirov
approved these changes
Feb 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NativeScript/nativescript-cli#3324