Tbozhikov/fix response code ios #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
After iOS runtime 5.3 was released some of the properties of the event arguments returned by the plugin are undefined/unset/incorrect values. Such is the
responseCodeproperty as described in #214The iOS Runtime bug related to this is:
NativeScript/ios-jsc#1149
What is the new behavior?
With this PR, some of the native iOS properties that were unable to be read after iOS Runtime v5.3 are now read in different ways:
NativePropertyReaderclass and its usage<native-iOS-instance>.performSelector("<property-name>")