Skip to content

Camera being covered by Tabview #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BMwanza opened this issue Sep 28, 2018 · 12 comments
Closed

Camera being covered by Tabview #128

BMwanza opened this issue Sep 28, 2018 · 12 comments

Comments

@BMwanza
Copy link

BMwanza commented Sep 28, 2018

Make sure to check the demo app(s) for sample usage

Make sure to check the existing issues in this repository

If the demo apps cannot help and there is no issue for your problem, tell us about it

Please, ensure your title is less than 63 characters long and starts with a capital
letter.

Which platform(s) does your issue occur on?

  • iOS
  • iOS 11.4
  • Real Device: iPhone 6

Please, provide the following version numbers that your issue occurs with:

  • CLI: 4.2.3

  • Cross-platform modules: (check the 'version' attribute in the
    node_modules/tns-core-modules/package.json file in your project)

  • Runtime(s): ios version: "version": "4.2.0"

  • Plugin(s): Plug in version: "nativescript-camera": "^4.0.2"

Please, tell us how to recreate the issue in as much detail as possible.

Describe the steps to reproduce it.
I have created a nativescript app using the tabview template, when launching the camera, it does not take the full screen, part of it is being blocked by the tabview

image

@tsonevn
Copy link
Contributor

tsonevn commented Oct 1, 2018

Hi @BMwanza,
Can you send us a sample project, which can be used for reproducing the problem?

@BMwanza
Copy link
Author

BMwanza commented Oct 1, 2018

Sure, here is a .zip of a sample project I just whipped up. Again I'm using the NativeScript tabview template and simply calling the Camera.takePicture() function within a page as the demo app I've attached shows.

Again, the bug seems to appear on physical iOS devices, it works well on Android both physical and real devices. Regarding iOS simulators, it is not possible to tell if the bug occurs given that the iOS simulators just launch the photos app when this function is called and not a real camera.

@tsonevn
Copy link
Contributor

tsonevn commented Oct 1, 2018

Hi @BMwanza,
Can you attach the project to the issue?

@BMwanza
Copy link
Author

BMwanza commented Oct 1, 2018

Sorry I thought it attatched, looks like the file is too big to be attatched to the issue, I'm going to make a git repo that you can just clone will that work?

@BMwanza BMwanza closed this as completed Oct 1, 2018
@BMwanza BMwanza reopened this Oct 1, 2018
@BMwanza
Copy link
Author

BMwanza commented Oct 1, 2018

@tsonevn Sorry for all the confusion, I also accidently closed this disucssion, but here is the project you can just clone it to run it
https://github.com/BMwanza/cameraBug

@chrisbekas
Copy link

Having this exact same issue on the device as described; iOS 12, latest {N} and camera plug-in.

@tsonevn tsonevn self-assigned this Oct 2, 2018
@BMwanza
Copy link
Author

BMwanza commented Oct 9, 2018

Hey @tsonevn how's this going, any progress? Please let me know if there is any other information I could provide to help assist with resolving this bug.

@tsonevn
Copy link
Contributor

tsonevn commented Oct 9, 2018

Hi @BMwanza,
The issue is still under review. We will provide the more info when we find how the problem can be solved. Also, any PR, which provides a fix, will be highly appreciated

@BMwanza
Copy link
Author

BMwanza commented Oct 22, 2018

Hi @tsonevn,

Any update on this? :)

Or is there a way to work around the bug like setting the tabview's visibility to hidden/collpased? It's just a pressing issue because our Development team is looking to submit our app as soon as possible

@tsonevn
Copy link
Contributor

tsonevn commented Oct 24, 2018

Hi @BMwanza,
The fix is already available in the master branch. We will publish a new version of the plugin soon.

@BMwanza
Copy link
Author

BMwanza commented Oct 24, 2018

Awesome!! Thanks so much @tsonevn and @lini on behalf of my entire dev team we really appreciate it!

@tsonevn
Copy link
Contributor

tsonevn commented Oct 24, 2018

HI all,
The new plugin version available in npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants