Skip to content

Error in "index.d.td" for function "requestPermissions" #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lord-saumagen opened this issue Jan 16, 2019 · 1 comment
Closed

Error in "index.d.td" for function "requestPermissions" #162

lord-saumagen opened this issue Jan 16, 2019 · 1 comment

Comments

@lord-saumagen
Copy link

Dear Ladies and Gentlemen,

it came to my attention that the definition of the "requestPermission" function is erroneous.
The function is implemented as an asynchronous function for android as well as for IOS. See
the pictures below.

image

image

The android implementation calls a function which returns a promise. The IOS implementation constructs a promise in the function implementation.

Unfortunately the type definition doesn't show that the function returns a promise. That made me
believe the function executes synchronously, which lead to some strange behaviors in my program.

image

It would be very nice if you could update the "index.d.ts" file.

Kind regards, Lord Saumagen.

@tgpetrov
Copy link
Contributor

tgpetrov commented Mar 5, 2019

Hi @lord-saumagen,
Thank you for your feedback. The change is made and will be included in the next release of the plugin.

@tgpetrov tgpetrov closed this as completed Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants