fix: make dimensions match orientation when keepAspectRatio is true #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
elena-p
force-pushed
the
hristova/make-dimensions-match-orientation-when-keepAspectRatio-true
branch
from
0aed22a to
2dbbcaf
Compare
lini
approved these changes
Nov 6, 2018
elena-p
deleted the
hristova/make-dimensions-match-orientation-when-keepAspectRatio-true
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When there are provided keepAspectRatio true, width and height, and an image is taken at the opposite mode, the returned image is bigger than expected.
Example: provided width (640) is greater than height (480) and a portrait image is taken, the returned image is 648x1152
#98
What is the new behavior?
When width and height don't match the picture orientation, and keepAspectRatio is true, width and height values will be swapped
In the example above: The returned image will be 480x640
Demos are updated to accept width, height and keepAspectRatio options.