Skip to content

chore: show the CLI diagram in a separate section with some explanations #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2018

Conversation

tbozhikov
Copy link
Contributor

No description provided.

Copy link
Contributor

@tjvantoll tjvantoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @tbozhikov. I again only had a few minor grammatical comments.

README.md Outdated

![NativeScript CLI diagram](https://github.com/NativeScript/nativescript-cli/blob/master/ns-cli.png)

* **Commands** - pretty much what every CLI do - support of different command options, input validation and help
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do --> does

README.md Outdated
![NativeScript CLI diagram](https://github.com/NativeScript/nativescript-cli/blob/master/ns-cli.png)

* **Commands** - pretty much what every CLI do - support of different command options, input validation and help
* **Devices Service** - it is the one that provides the communication between NativeScript and devices/emulators/simulators used to run/debug the app. Uses iTunes to talk to iOS and adb for Android
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove “it is the one that”.

README.md Outdated

* **Commands** - pretty much what every CLI do - support of different command options, input validation and help
* **Devices Service** - it is the one that provides the communication between NativeScript and devices/emulators/simulators used to run/debug the app. Uses iTunes to talk to iOS and adb for Android
* **LiveSync Service** - initiates application redeploy on application code changes while development
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redeploys applications when code changes during development

README.md Outdated
* **Commands** - pretty much what every CLI do - support of different command options, input validation and help
* **Devices Service** - it is the one that provides the communication between NativeScript and devices/emulators/simulators used to run/debug the app. Uses iTunes to talk to iOS and adb for Android
* **LiveSync Service** - initiates application redeploy on application code changes while development
* **Hooks Service** - executes custom-written hooks in developed application, thus modifying build process
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the build process

Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@tbozhikov tbozhikov merged commit 8125d4b into master Jan 15, 2018
@rosen-vladimirov rosen-vladimirov deleted the tbozhikov/revisit-cli-diagram branch July 13, 2018 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants