Fix livesync + debug on iOS Simulator #3334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
requested review from
KristianDD,
Mitko-Kerezov and
TsvetanMilanov
rosen-vladimirov
force-pushed
the
vladimirov/fix-ios-sim-debug-livesync
branch
from
2d2c638 to
06db1e4
Compare
TsvetanMilanov
approved these changes
Jan 23, 2018
rosen-vladimirov
force-pushed
the
vladimirov/fix-ios-sim-debug-livesync
branch
from
06db1e4 to
a60bdb1
Compare
lib/services/ios-debug-service.ts
Outdated
| @@ -212,7 +225,7 @@ export class IOSDebugService extends DebugServiceBase implements IPlatformDebugS | |||
| this.$logger.info("'--chrome' is the default behavior. Use --inspector to debug iOS applications using the Safari Web Inspector."); | |||
| } | |||
|
|
|||
| this._socketProxy = await this.$socketProxyFactory.createWebSocketProxy(this.getSocketFactory(device)); | |||
| this._socketProxy = await this.$socketProxyFactory.createWebSocketProxy(this.getSocketFactory(device), device.deviceInfo.identifier); | |||
There was a problem hiding this comment.
device is not a mandatory argument, so you may receive Cannot read property 'deviceInfo' of undefined.
When `tns debug ios` is used, each change of application's code will trigger restart of app and Chrome DevTools will be disconnected. CLI prints the "new" URL and in case you copy it and paste it immediately in the browser, you'll receive empty DevTools. The problem is that the URL is printed before application is launched successfully on simulator. In order to resolve this issue, try connection on port 18181 - the connection will be successfull only when the application is running. Wait 10 seconds to connect and throw error in case we are unable to connect for this time. Also fix incorrect behavior of connectionError event - the thrown error should contain the deviceIdentifier, but it was missing.
rosen-vladimirov
force-pushed
the
vladimirov/fix-ios-sim-debug-livesync
branch
from
a60bdb1 to
73bb06b
Compare
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
tns debug iosis used, each change of application's code will trigger restart of app and Chrome DevTools will be disconnected. CLI prints the "new" URL and in case you copy it and paste it immediately in the browser, you'll receive empty DevTools. The problem is that the URL is printed before application is launched successfully on simulator.In order to resolve this issue, try connection on port 18181 - the connection will be successfull only when the application is running. Wait 10 seconds to connect and throw error in case we are unable to connect for this time.
Also fix incorrect behavior of connectionError event - the thrown error should contain the deviceIdentifier, but it was missing.
NOTE: Merge after telerik/mobile-cli-lib#1041