Start livesync watcher before preparing the project #3576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
force-pushed
the
fatme/watch
branch
2 times, most recently
from
ccaafd8 to
caeba7f
Compare
|
run ci |
|
run ci |
rosen-vladimirov
suggested changes
May 15, 2018
lib/services/files-hash-service.ts
Outdated
| const result: IStringDictionary = {}; | ||
|
|
||
| const action = async (file: string) => { | ||
| if (this.$fs.getFsStats(file).isFile()) { |
There was a problem hiding this comment.
maybe you should try-catch this call, in case someone deletes the file while we are executing a previous chunk
| @@ -58,9 +59,12 @@ export class ProjectChangesService implements IProjectChangesService { | |||
| public async checkForChanges(platform: string, projectData: IProjectData, projectChangesOptions: IProjectChangesOptions): Promise<IProjectChangesInfo> { | |||
| const platformData = this.$platformsData.getPlatformData(platform, projectData); | |||
| this._changesInfo = new ProjectChangesInfo(); | |||
| if (!this.ensurePrepareInfo(platform, projectData, projectChangesOptions)) { | |||
| const isPrepareInfoEnsured = await this.ensurePrepareInfo(platform, projectData, projectChangesOptions); | |||
There was a problem hiding this comment.
maybe the variable should be called isNewPrepareInfo
| @@ -300,5 +305,20 @@ export class ProjectChangesService implements IProjectChangesService { | |||
| } | |||
| return false; | |||
| } | |||
|
|
|||
| private getAppFiles(appDirectoryPath: string): string[] { | |||
| return this.$fs.enumerateFilesInDirectorySync(appDirectoryPath, (filePath: string, stat: IFsStats) => filePath.indexOf(APP_RESOURCES_FOLDER_NAME) === -1); | |||
There was a problem hiding this comment.
maybe it is better to ensure the path.basename(filePath) !== appresources name
You should not use the APP_RESOURCES_FOLDER_NAME constant here - you should read the value from projectData as by using .nsconfig the user might change directory's name.
rosen-vladimirov
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Currently the project is prepared and after that a livesync watcher is started.
What is the new behavior?
LiveSync watcher is started and after that the project is prepared.
Implemented #3404