chore: fix console.log regression after introducing ios-sim async api #3722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
suggested changes
Jul 4, 2018
| if (device.isEmulator) { | ||
| return this.$iOSSimulatorLogProvider.startNewMutedLogProcess(device.deviceInfo.identifier); | ||
| } | ||
|
|
||
| return this.$iosDeviceOperations.startDeviceLog(device.deviceInfo.identifier); | ||
| return Promise.resolve(this.$iosDeviceOperations.startDeviceLog(device.deviceInfo.identifier)); |
There was a problem hiding this comment.
you can make the method async and just return the this.$iosDeviceOperations.startDeviceLog(device.deviceInfo.identifier) call here.
| @@ -17,6 +17,6 @@ export class AndroidLiveSyncService extends PlatformLiveSyncServiceBase implemen | |||
| return service; | |||
| } | |||
|
|
|||
| public prepareForLiveSync(device: Mobile.IDevice, data: IProjectDir): void { /* */ } | |||
| public prepareForLiveSync(device: Mobile.IDevice, data: IProjectDir): Promise<void> { return Promise.resolve(); } | |||
There was a problem hiding this comment.
Marking the method as async would be enough, no need to return Promise.resolve()
| @@ -66,9 +66,9 @@ export class IOSLiveSyncService extends PlatformLiveSyncServiceBase implements I | |||
| } | |||
| } | |||
|
|
|||
| public prepareForLiveSync(device: Mobile.IDevice, data: IProjectDir, liveSyncInfo: ILiveSyncInfo): void { | |||
| public prepareForLiveSync(device: Mobile.IDevice, data: IProjectDir, liveSyncInfo: ILiveSyncInfo): Promise<void> { | |||
There was a problem hiding this comment.
this method must be marked as async as in case skipWatcher is true, it will not return promise
Fatme
force-pushed
the
fatme/fix-console-log
branch
from
69798e9 to
74f9d04
Compare
rosen-vladimirov
approved these changes
Jul 4, 2018
Fatme
force-pushed
the
fatme/fix-console-log
branch
from
74f9d04 to
e1a436b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
tns run iosdoes not print the logs from iOS simulatorWhat is the new behavior?
tns run iosprints the logs from iOS simulator