Skip to content

fix: alpha issue #5420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2020
+7 −1
Merged

fix: alpha issue #5420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/services/assets-generation/assets-generation-service.ts
View file
Original file line number Diff line number Diff line change
@@ -157,7 +157,13 @@ export class AssetsGenerationService implements IAssetsGenerationService {

// This code disables the alpha chanel, as some images for the Apple App Store must not have transparency.
if (assetItem.rgba === false) {
image = image.rgba(false);
//
// The original code here became broken at some time and there is an issue posted here..
// https://github.com/oliver-moran/jimp/issues/954
// But NathanaelA recommended the below change and it works so maybe that's just what we go with.
//
// image = image.rgba(false);
image = image.colorType(2);
}

image.write(outputPath);