Skip to content

Fix many 'file change detected' messages #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jun 18, 2018

Fixes NativeScript/nativescript-cli#3687

When tns run android command is executed, a typescript watcher is started. When project is prepared {N} CLI moves all files in platforms directory. This triggers a typescript watcher to print File change detected. Starting incremental compilation... message many times. This PR hides all messages from typescript compiler except errors. So the user will see only typescript errors. Actually when the command is executed with --log trace option, all messages from typescript compiler will be printed.

PR Checklist

What is the current behavior?

Many File change detected. Starting incremental compilation... messages are printed when tns run android command is executed.

What is the new behavior?

Only error messages from typescript compiler are printed.

Fixes NativeScript/nativescript-cli#3687

When `tns run android` command is executed, a typescript watcher is started. When project is prepared {N} CLI moves all files in platforms directory. This triggers a typescript watcher to print `File change detected. Starting incremental compilation...` message many times. This PR hides all messages from typescript compiler except errors. So the user will see only typescript errors. Actually when the command is executed with --log trace option, all messages from typescript compiler will be printed.
@Fatme Fatme requested a review from rosen-vladimirov June 18, 2018 13:50
@Fatme Fatme merged commit dc03945 into master Jun 22, 2018
@Fatme Fatme deleted the fatme/fix-many-file-change-detected branch June 22, 2018 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants