Skip to content

fix number of row for debug tests #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2019
Merged

fix number of row for debug tests #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions tests/cli/debug/test_debug_js.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,9 @@ def __debug_sources(self, platform, device):
# Open sources tab and verify content is loaded
self.dev_tools = ChromeDevTools(self.chrome, platform=platform, tab=ChromeDevToolsTabs.SOURCES)

# Open JS file and place breakpoint on line 17
# Open JS file and place breakpoint on line 18
self.dev_tools.load_source_file("main-view-model.js")
self.dev_tools.breakpoint(17)
self.dev_tools.breakpoint(18)

# Tap on TAP button in emulator and check it is hit
device.click(text="TAP", case_sensitive=True)
Expand All @@ -205,9 +205,9 @@ def __debug_sync_changes(self, platform, device):
# Open sources tab and verify content is loaded
self.dev_tools = ChromeDevTools(self.chrome, platform=platform, tab=ChromeDevToolsTabs.SOURCES)

# Open JS file and place breakpoint on line 17
# Open JS file and place breakpoint on line 18
self.dev_tools.load_source_file("main-view-model.js")
self.dev_tools.breakpoint(17)
self.dev_tools.breakpoint(18)

# Sync JS changes works fine until breakpoint is hit
Sync.replace(app_name=self.app_name, change_set=Changes.JSHelloWord.JS)
Expand Down Expand Up @@ -249,10 +249,10 @@ def __debug_watch_expression(self, platform, device):
Tns.debug(app_name=self.app_name, platform=platform, emulator=True)
device.wait_for_text(text='TAP')

# Open sources tab and place breakpoint on line 17 of main-view-model.js
# Open sources tab and place breakpoint on line 18 of main-view-model.js
self.dev_tools = ChromeDevTools(self.chrome, platform=platform, tab=ChromeDevToolsTabs.SOURCES)
self.dev_tools.load_source_file("main-view-model.js")
self.dev_tools.breakpoint(17)
self.dev_tools.breakpoint(18)

# Tap on TAP button in emulator and check it is hit
device.click(text="TAP", case_sensitive=True)
Expand Down Expand Up @@ -301,7 +301,7 @@ def __debug_start(self, platform, device):
# Verify debug is working (covers https://github.com/NativeScript/nativescript-cli/issues/2831)
self.dev_tools.open_tab(ChromeDevToolsTabs.SOURCES)
self.dev_tools.load_source_file("main-view-model.js")
self.dev_tools.breakpoint(17)
self.dev_tools.breakpoint(18)
device.click(text="TAP", case_sensitive=True)
pause_element = self.dev_tools.wait_element_by_text(text="Paused on breakpoint", timeout=10)
assert pause_element is not None, 'Failed to pause on breakpoint.'
Expand Down