This repository was archived by the owner on Mar 21, 2019. It is now read-only.
[Android] Improve images handling #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitarTachev
commented
Nov 30, 2017
DimitarTachev
commented
- scale to exact size (not up to 2x size)
- rotate the bitmap based on the source image rotation
- support for keepAspectRation (based on ImageAsset.keepAspectRatio or Image.Stretch != fill)
- scale properly and optimized based on keepAspectRatio even when only width or height specified (previously the whole image was read in such cases)
- fixed inSampleSize calculations (the no more than 2x pixels logic was causing issues like getting 1/32 of a picture instead of 1/8)
…ampleSize size -> 4x less pixels)
…ested. Added rotation and scaling while processing images. Added keepAspectRatio property for further flexibility and accuracy.
ADjenkov
force-pushed
the
tachev/improve-images-handling
branch
from
fc3c558 to
f369dfd
Compare
ADjenkov
approved these changes
Feb 28, 2018
| @@ -420,21 +537,14 @@ public static Bitmap decodeSampledBitmapFromFile(String filename, | |||
| * that are equal to or greater than the requested width and height | |||
| */ | |||
| public static Bitmap decodeSampledBitmapFromDescriptor( | |||
There was a problem hiding this comment.
Just a suggestion: add @param comment for keepAspectRatio will be would be very useful. For me, as a person who looks at this code for the very first time, the coments and params descriptions were more than welcome
| @@ -499,13 +610,14 @@ public static Bitmap decodeSampledBitmapFromByteArray( | |||
| * @return The value to be used for inSampleSize | |||
| */ | |||
| public static int calculateInSampleSize(BitmapFactory.Options options, | |||
| int reqWidth, int reqHeight) { | |||
| int reqWidth, int reqHeight, boolean keepAspectRatio) { | |||
There was a problem hiding this comment.
keepsAsprctRatio is not use in this method. Consider using it?
| else { | ||
| options.inSampleSize = 1; | ||
| } | ||
| options.inSampleSize = calculateInSampleSize(options, reqWidth, reqHeight, keepAspectRatio); |
There was a problem hiding this comment.
Consider using this calculateInSampleSize from JS (unify params) and write tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.