Skip to content
This repository was archived by the owner on Mar 21, 2019. It is now read-only.

fix(Android): ExifInterface to use support lib #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NathanWalker
Copy link
Contributor

PR Checklist

What is the current behavior?

Android apps can become unstable due to old usage of error prone ExifInterface class:
https://stackoverflow.com/a/44246248/2192332

02-06 18:55:03.396 10629 10629 W ExifInterface: Invalid image: ExifInterface got an unsupported image format file(ExifInterface supports JPEG and some RAW image formats only) or a corrupted JPEG file to ExifInterface.
02-06 18:55:03.396 10629 10629 W ExifInterface: java.io.IOException: Invalid marker: 89
02-06 18:55:03.396 10629 10629 W ExifInterface: 	at android.media.ExifInterface.getJpegAttributes(ExifInterface.java:1885)
02-06 18:55:03.396 10629 10629 W ExifInterface: 	at android.media.ExifInterface.loadAttributes(ExifInterface.java:1517)
02-06 18:55:03.396 10629 10629 W ExifInterface: 	at android.media.ExifInterface.<init>(ExifInterface.java:1216)
02-06 18:55:03.396 10629 10629 W ExifInterface: 	at org.nativescript.widgets.image.Fetcher.getExifInterface(Fetcher.java:402)
02-06 18:55:03.396 10629 10629 W ExifInterface: 	at org.nativescript.widgets.image.Fetcher.decodeSampledBitmapFromResource(Fetcher.java:392)

What is the new behavior?

Android apps will remain stable.

Related: NativeScript/NativeScript#6868

@NathanWalker NathanWalker force-pushed the fix/android-exifinterface-support branch from 24f99bd to a3341d4 Compare February 24, 2019 05:27
@SvetoslavTsenov
Copy link
Contributor

test

@SvetoslavTsenov
Copy link
Contributor

Hey @NathanWalker,
I want to notify you that the NativeScript/tns-core-modules-widgets repository is being moved to the NativeScript/NativeScript repository in an effort to streamline the maintenance and the QA processes. The tns-core-modules-widgets repository will be archived soon. We advise you to merge this PR with the one that you have already opened in NativeScript/NativeScript repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants