fix(FlexboxLayout): issue #6156 and replace auto RTL detected by manual

[xlmnxp]

PR Checklist

• The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
• There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
• You have signed the CLA.
• All existing tests are passing
• Tests for the changes are included

What is the current behavior?

I replaced auto RTL detected by manual detected

What is the new behavior?

I replaced auto RTL detected by manual detected
new you can change direction FlexboxLayout ( by default is LTR ) by setRtl(boolean rtl)
Fixes #6156.

BREAKING CHANGES:

• add new variable named mIsRtl by default false
• add getter and setter for RTL value.
• replace device RTL detected by mIsRtl

[manoldonev]

@xlmnxp your modifications are in java (Android) code while NativeScript/NativeScript#6156 is related to an iOS issue.

Also, I don't think the proposed change of replacing automatic with manual rtl detection for Android has an added benefit.

[xlmnxp]

@manoldonev I'm working on a project that adds support for RTL layouts
This Flexbox Layout should disable RTL support to work as compatible with the plugin.

https://github.com/nativescript-rtl/ui

[manoldonev]

Ok but this change disables automatic rtl detection for the built-in NativeScript FlexboxLayout even in scenarios where your rtl plugin is not used. I think you should explore other options to achieve the desired effect e.g. implement your new property / override onLayout(...) in your own class that extends FlexboxLayout (as far as I can see that is the approach you are using for the rest of the layout classes).

[xlmnxp]

@manoldonev FlexboxLayout is an anomaly for other layouts where it is the only one that detect the right-to-left direction automatically and the problem is that that it is only in the android system.
It is best to support automatic detect of the right-to-left direction in all other layouts or remove support from it only

[manoldonev]

@xlmnxp I agree that best option is to support automatic rtl detection out-of-the-box.

As for your PR -- we are not prepared to introduce such kind of breaking change for the FlexboxLayout. Alternative option could be to introduce a three-way rtlMode property (enum or Boolean) that would keep the current automatic behavior as default but would allow you to set it manually for your plugin scenarios.

[xlmnxp]

@manoldonev ok I'll do it

[manoldonev]

@xlmnxp btw I was wondering did you consider extending the automatic rtl support within the built-in NativeScript core modules via community PR before deciding to implement your plugin?

if yes -- what kind of problems did you encounter?

[SvetoslavTsenov]

Hey @xlmnxp,
I want to notify you that the NativeScript/tns-core-modules-widgets repository is being moved to the NativeScript/NativeScript repository in an effort to streamline the maintenance and the QA processes. The tns-core-modules-widgets repository will be archived soon. We advise you to open a new PR in the NativeScript/NativeScript with the suggested changes and we will be happy to review it.