Add Unit tests for the Pill #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you for PR. A few things:
|
|
@Neha Apologies for neglecting the assigned field. Point noted for future. |
|
The test coverage is now 83.33%. The tests for keyboard events are not added yet. I will be able to add it on the weekend. If this looks satisfactory, feel free to merge.
|
|
Coverage after adding tests for keyboard events |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added unit tests for Pill using Jest and React Testing Library. With this PR, the coverage becomes 100% 🎉(EDIT: 83.33% now)
Issue #17