Add EngineRequestGenerator tool #7266
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thermindEth/nethermind into feature/requests_generator_v2 # Conflicts: # tools/EngineRequestsGenerator/TestCaseGenerator.cs
…nto feature/requests_generator_v2_modexp_vulnerabilities # Conflicts: # tools/EngineRequestsGenerator/TestCase.cs # tools/EngineRequestsGenerator/TestCaseGenerator.cs
|
|
||
| // Eip4788 precompile state account | ||
| if (specProvider?.GenesisSpec?.IsBeaconBlockRootAvailable ?? false) | ||
| if (!keepStateEmpty) |
There was a problem hiding this comment.
Instead of adding a parameter maybe better to:
- Put below state modifying code into virtual method and then override it and do nothing.
- Have a property That indicates if state should be empty - set it or override it in usages.
Comment on lines
+18
to
+20
| List<byte> currentWord = i == 0 | ||
| ? initCode.Slice(0, initCode.Count % 32) | ||
| : initCode.Slice((int)i - 32 + initCode.Count % 32, 32); |
|
|
||
| // push memory offset - i | ||
| byte[] memoryOffset = i.ToBigEndianByteArrayWithoutLeadingZeros(); | ||
| if (memoryOffset is [0]) |
| } | ||
|
|
||
| // push size of init code to read from memory | ||
| byte[] sizeOfInitCode = initCode.Count.ToByteArray().WithoutLeadingZeros().ToArray(); |
| return byteCode; | ||
| } | ||
|
|
||
| private static List<byte> GenerateInitCode(List<byte> codeToDeploy) |
Comment on lines
+27
to
+29
| var str = JsonConvert.SerializeObject(metadatas); | ||
|
|
||
| await File.WriteAllTextAsync($"{_outputPath}/metadata.json", str); |
There was a problem hiding this comment.
Serialize directly to file
Comment on lines
+56
to
+59
| if (attributes == null || attributes.Length != 1) | ||
| throw new ArgumentException("Incorrect amount of attributes found"); | ||
|
|
||
| return attributes[0]; |
There was a problem hiding this comment.
Suggested change
| if (attributes == null || attributes.Length != 1) | |
| throw new ArgumentException("Incorrect amount of attributes found"); | |
| return attributes[0]; | |
| return attributes?.First() ?? throw new ArgumentException("Incorrect amount of attributes found"); |
| codeToDeploy.Add((byte)Instruction.MSTORE8); | ||
|
|
||
|
|
||
| byte[] stateVector = new byte[64]; |
| codeToDeploy.Add((byte)Instruction.MSTORE); | ||
|
|
||
|
|
||
| byte[] messageBlockVector = new byte[128]; |
…nerator_v2 # Conflicts: # src/Nethermind/Nethermind.Core.Test/Blockchain/TestBlockchain.cs
…plorations' into feature/requests_generator_v2_vulnerabilitiesv2 # Conflicts: # tools/EngineRequestsGenerator/TestCase.cs # tools/EngineRequestsGenerator/TestCaseGenerator.cs # tools/EngineRequestsGenerator/TestCases/Modexp.cs
This reverts commit 46b9e33
…eature/requests_generator_v2
…nerator_v2 # Conflicts: # src/Nethermind/Nethermind.Core.Test/Blockchain/TestBlockchain.cs # src/Nethermind/Nethermind.Merge.Plugin.Test/BaseEngineModuleTests.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Despite of more than 3500 lines of code it is safe to be merged to the master - most of lines is just newly added code to
EngineRequestGeneratorproject. From main solution, only 2 classes are modified:Types of changes
Testing
Requires testing
Documentation
Requires documentation update