nix flake show
: Skip IFDs instead of throwing
#12583
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As mentioned in #4265 (comment),
nix flake show
fails if it encounters an IFD while it's trying to show the derivations inside the flake. This means thatnix flake show
is effectively broken if you are using IFD's in almost any place in your flake.Context
Following
--all-systems
,nix flake show
now shows an "omitted" message when it encounters an IFD. To this end, I gave IFD errors an explicit type that made this possible.Example output with this patch:
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.