Implement web #15
Open
Implement web #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added package.json for dependency management and build scripts. - Created pubspec.yaml to define package metadata and dependencies. - Implemented Peripherals class for keyboard navigation. - Developed preferences management functions for user settings. - Built ReadiumReader class to handle publication loading and navigation. - Added CSS styles for the web interface. - Configured TypeScript and Webpack for module bundling. - Created index.html as the entry point for the web application.
…ation method and managing publications in a static map
- Renamed the method `updatePreferences` to `setEPUBPreferences` to better match naming convention in FlutterReadium - Modified the logic for handling null or undefined preferences to ensure a default empty object is used. - Changed the default theme in preferences from 'day' to 'custom' as day has been removed. - Cleaned up the preferences module by renaming the original `setPreferencesFromString` to `initializePreferencesFromString` and `updatePreferences` to `setPreferencesFromString` for clarity.
…les to latest beta versions
…l and ReadiumWebView
… and type normalization
…tializing navigator
m-abs
reviewed
Aug 6, 2025
| @@ -63,10 +63,12 @@ abstract class Locator with _$Locator { | |||
| // Only set id fragments to less confusing readium. | |||
| final selector = locations?.cssSelector ?? locations?.domRange?.start.cssSelector; | |||
| final idFragment = selector?.startsWith('#') == true ? selector!.substring(1) : null; | |||
| // Make sure href only contains path. | |||
| final locationHref = hrefPath.startsWith('/') ? hrefPath.substring(1) : hrefPath; | |||
There was a problem hiding this comment.
Only contains path? This would make /some/path/to/file.json into some/path/to/file.json, but keep https://domain.dk/some/path/to/file.json as is.
There was a problem hiding this comment.
if it starts with / we get issues because readium itself already has it
| @@ -64,7 +73,9 @@ class BookshelfPageState extends State<BookshelfPage> { | |||
|
|
|||
| Future<Publication?> openPublicationFromUrl(String pubUrl) async { | |||
| try { | |||
| Publication pub = await _flutterReadiumPlugin.openPublication(pubUrl); | |||
| Publication pub = kIsWeb | |||
There was a problem hiding this comment.
Maybe we could generalize this, so all platforms use the same function here?
There was a problem hiding this comment.
What @ddfreiling has written for native uses openPublication, but that is not possible with ts-toolkit. We need to make another PR with implements getPublication in native and then we can generalize it. Until then this should stay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.