-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Encoding Object examples have invalid schema property #3170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I noticed 3.1.0 has a slightly different schema, albeit, valid. Lmk if you want that updated too. addresses:
# default Content-Type for arrays is based on the _inner_ type (object shown, so `application/json` in this example)
type: array
items:
type: object
$ref: '#/components/schemas/Address' cc @handrews let me know if this should be fixed too. |
@jeremyfiel I'm not sure what would need to be fixed in the 3.1 schema? I might be missing something. |
the `type: object` is redundant with a `$ref` sibling
…On Wed, Mar 1, 2023 at 2:16 PM Henry Andrews ***@***.***> wrote:
@jeremyfiel <https://github.com/jeremyfiel> I'm not sure what would need
to be fixed in the 3.1 schema? I might be missing something.
—
Reply to this email directly, view it on GitHub
<#3170 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHU7MTNBUGCSSRETKM2U533WZ6OA3ANCNFSM6AAAAAAVHIZ7AU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@jeremyfiel I suspect I put it in there just to emphasize that you can put things next to |
i'm impartial. |
Let's leave it as-is and just fix it for 3.0.4. |
This has been fixed in 3.0.4 and we decided not to change it in 3.1.1. |
Reviewing the Encoding Object Examples
The keyword
type
should be$ref
.The text was updated successfully, but these errors were encountered: