Skip to content

Fixes Inconsistent JSON spacing #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2021
Merged

Fixes Inconsistent JSON spacing #2543

merged 2 commits into from
May 27, 2021

Conversation

ArishSultan
Copy link
Contributor

the whole document uses 2-space indentation but at some places, 4-space indentation is used which is not consistent with the others.

@ArishSultan
Fixes Inconsistent JSON spacing
387a71e 
the whole document uses 2-space indentation but at some places, 4-space indentation is used which is not consistent with the others.
@ArishSultan
Copy link
Contributor Author

@MikeRalphson

@ArishSultan
Copy link
Contributor Author

just a ping, anyone here?

MikeRalphson
MikeRalphson suggested changes May 5, 2021
View reviewed changes
Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. There appears to be at least one case of a json code block being indented by 3 spaces (the first example for array formatting). Could you also fix that one?

MikeRalphson
MikeRalphson approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks.

@webron
Copy link
Member

webron commented May 27, 2021

Thanks for the update!

@webron webron merged commit 682860d into OAI:v3.1.1-dev May 27, 2021
charjr pushed a commit to charjr/OpenAPI-Specification that referenced this pull request Apr 27, 2023
@ArishSultan @charjr
Fixes Inconsistent JSON spacing (OAI#2543)
be4dbdb 
* Fixes Inconsistent JSON spacing

the whole document uses 2-space indentation but at some places, 4-space indentation is used which is not consistent with the others.

* Fixed 3-spaced indent in Format section's example
charjr pushed a commit to charjr/OpenAPI-Specification that referenced this pull request Apr 27, 2023
@ArishSultan @charjr
Fixes Inconsistent JSON spacing (OAI#2543)
38d4d56 
* Fixes Inconsistent JSON spacing

the whole document uses 2-space indentation but at some places, 4-space indentation is used which is not consistent with the others.

* Fixed 3-spaced indent in Format section's example
@handrews handrews added this to the v3.1.1 milestone May 17, 2024
@handrews handrews added bug examples requests for more or better examples in the specification labels May 17, 2024
@lornajane lornajane mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeRalphson MikeRalphson MikeRalphson approved these changes

Assignees
No one assigned
Labels
bug examples requests for more or better examples in the specification
Projects
None yet
Milestone
v3.1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ArishSultan @webron @MikeRalphson @handrews