Skip to content

dev: schema tests output reason if "pass" test fixture fails #4455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

dev: schema tests output reason if "pass" test fixture fails #4455

merged 1 commit into from
Mar 20, 2025

Conversation

ralfhandl
Copy link
Contributor

This is a quality-of-life improvement for writing "pass" test fixtures: output validation errors if a "pass" test fixture fails validation.

Tick one of the following options:

  • schema changes are included in this pull request
  • schema changes are needed for this pull request but not done yet
  • no schema changes are needed for this pull request

@ralfhandl ralfhandl requested review from a team as code owners March 18, 2025 12:02
@ralfhandl ralfhandl mentioned this pull request Mar 18, 2025
Closed
duncanbeevers
duncanbeevers approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@duncanbeevers duncanbeevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fine change, but I think the PR would be easier to review if you showed exactly what a failure looked like before, and what it looks like with this change applied.

This was referenced Mar 18, 2025
Merged
Merged
@handrews handrews merged commit c555c94 into OAI:dev Mar 20, 2025
2 checks passed
@ralfhandl ralfhandl deleted the dev-schema-tests.-with-diagnostics branch March 20, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanbeevers duncanbeevers duncanbeevers approved these changes

@handrews handrews handrews approved these changes

@miqui miqui miqui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ralfhandl @duncanbeevers @handrews @miqui