-
Notifications
You must be signed in to change notification settings - Fork 9.1k
feat: adds additional operations for path item object #4514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
701d460
feat: adds additional operations for path item object
baywet 524cc6f
chore: adds test data for additional operations
baywet b12f34b
fix: schema definition for outlawed properties
baywet 692b413
fix: schema indentation and adds required keyword
baywet 62dbf31
fix: 🤦 vincent needs a coffee
baywet 15e99ca
Apply suggestions from code review
baywet 72a29d7
Update tests/schema/pass/path-item-object-example.yaml
baywet 2452ad1
chore: moves additional operations after the defined operations
baywet 4cf5168
ci: adds a failing test for methods that should be defined on the par…
baywet cfdc4bc
Update tests/schema/fail/path-item-object-example.yaml
baywet d5141ec
chore: renames fail file to have more explicit definition of the case
baywet 6ed7fe8
feat: adds query as "principal" operation type in path item
baywet 61fee04
fix: excluded operations filter for additional operations
baywet d3c477c
docs: updates wording for additional operations exclusions
baywet 2dc3e06
docs: updates additional operation samples to match hoisting of query
baywet e465abc
Merge branch 'feat/additional-operations' of https://github.com/baywe…
baywet 3fb4d91
ci: fixes pass example test
baywet dd0cf16
docs: adds a query example to pass tests
baywet fc29d3a
docs: precisions around capitalization
baywet 9a53a9d
ci: restricts to RFC9110 methods syntax
baywet 621d1c3
docs: adds the query method to the spec
baywet ed5cfe4
fix: tchar definition
baywet 480dc75
Fix regex character class
handrews 1826161
Fix character class in regular expression
handrews 3ee2d24
Undo my incorrect additional "fix"
handrews 0c4f6be
docs: typo fix in html attribute name
baywet 238aaca
docs: schema regex fix
baywet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
tests/schema/fail/path-item-object-conflicting-additional-operation.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
openapi: 3.2.0 | ||
info: | ||
title: API | ||
version: 1.0.0 | ||
paths: | ||
/pets/{id}: | ||
get: | ||
description: Returns pets based on ID | ||
summary: Find pets by ID | ||
operationId: getPetsById | ||
responses: | ||
'200': | ||
description: pet response | ||
content: | ||
'*/*': | ||
schema: | ||
type: array | ||
items: | ||
$ref: '#/components/schemas/Pet' | ||
default: | ||
description: error payload | ||
content: | ||
text/html: | ||
schema: | ||
$ref: '#/components/schemas/ErrorModel' | ||
parameters: | ||
- name: id | ||
in: path | ||
description: ID of pet to use | ||
required: true | ||
schema: | ||
type: array | ||
items: | ||
type: string | ||
style: simple | ||
additionalOperations: | ||
POST: | ||
description: Returns pets based on ID | ||
summary: Find pets by ID | ||
operationId: postPetsById | ||
requestBody: | ||
description: ID of pet to use | ||
required: true | ||
content: | ||
application/json: | ||
schema: | ||
type: array | ||
items: | ||
type: string | ||
responses: | ||
'200': | ||
description: pet response | ||
content: | ||
'*/*': | ||
schema: | ||
type: array | ||
items: | ||
$ref: '#/components/schemas/Pet' | ||
default: | ||
description: error payload | ||
content: | ||
text/html: | ||
schema: | ||
$ref: '#/components/schemas/ErrorModel' |
ralfhandl marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.