-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Clenup JS test. Resolve external $ref during tests. #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@webron I force Travis run on this PR and it pass. |
Hi, all tests for OAI V3 should be against the OpenApi.next branch. |
@fehguy Hi, thank you for reply.
It's not intended for OAI V3. It's fixing and improving test for Swagger v2.0. Can you please review it? P.S. same code can be extended to validate OAI V3 in future. So this PR important for both versions. |
Code is very simple and straightforward and takes only 63 lines after cleanup. |
Clenup JS test. Resolve external $ref during tests.
@IvanGoncharov we should probably decide first that that's the current goal. That discussion was prior to the OAI. |
@webron I understand. As for my personal goals, I want to push few schema fixes to |
Clenup JS test. Resolve external $ref during tests.
Main improvements:
package.json
. Mark it as private package to forbid publishing.swagger-validator
is totally [different] https://www.npmjs.com/package/swagger-validator) package on npm.z-schema
.tv4
validation. It was failing for long period and was marked as expected. Another point is I'm working on switching unittests from Java to JS as disscussed here, and it easy to do onz-schema
but is very hard ontv4
.@webron Can you please review it?