Skip to content

Clenup JS test. Resolve external $ref during tests. #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2016
Merged

Clenup JS test. Resolve external $ref during tests. #591

merged 1 commit into from
Mar 15, 2016

Conversation

IvanGoncharov
Copy link
Contributor

Main improvements:

  • cleanup package.json. Mark it as private package to forbid publishing. swagger-validator is totally [different] https://www.npmjs.com/package/swagger-validator) package on npm.
  • Update all dependencies related to tests. Biggest update is z-schema.
  • Remove tv4 validation. It was failing for long period and was marked as expected. Another point is I'm working on switching unittests from Java to JS as disscussed here, and it easy to do on z-schema but is very hard on tv4.

@webron Can you please review it?

@IvanGoncharov
Copy link
Contributor Author

@webron I force Travis run on this PR and it pass.
Please review it so I can continue with switching unit tests from Java to JS.

@fehguy
Copy link
Contributor

fehguy commented Mar 3, 2016

Hi, all tests for OAI V3 should be against the OpenApi.next branch.

@IvanGoncharov
Copy link
Contributor Author

@fehguy Hi, thank you for reply.

all tests for OAI V3 should be against the OpenApi.next branch.

It's not intended for OAI V3. It's fixing and improving test for Swagger v2.0.
I'm working with 200+ Swagger 2.0 spec so I'm really interested in improving JSON Schema which validate them. With PRs like #413 but it's blocked by current tests.

Can you please review it?

P.S. same code can be extended to validate OAI V3 in future. So this PR important for both versions.

@IvanGoncharov
Copy link
Contributor Author

Code is very simple and straightforward and takes only 63 lines after cleanup.

@IvanGoncharov
Copy link
Contributor Author

@fehguy @webron Can you please take a look?

@IvanGoncharov
Copy link
Contributor Author

@fehguy Can you please review it?
Especially since you add the same broken test suite into OpenAPI.next as part of #597.

fehguy added a commit that referenced this pull request Mar 15, 2016
Clenup JS test. Resolve external $ref during tests.
@fehguy fehguy merged commit 3cb58cd into OAI:master Mar 15, 2016
@IvanGoncharov
Copy link
Contributor Author

@fehguy Thank you.
I will start working on switching unit tests from Java to JS as discussed here.

@webron
Copy link
Member

webron commented Mar 16, 2016

@IvanGoncharov we should probably decide first that that's the current goal. That discussion was prior to the OAI.

@IvanGoncharov
Copy link
Contributor Author

@webron I understand.
My argument will be that OpenAPI.next should keep JSON Schema in sync with spec changes.
That mean it will benefit from having fully working and maintainable test suite.

As for my personal goals, I want to push few schema fixes to 2.0 or next what will better suit them.
Most important fix is #598.

AndersDJohnson pushed a commit to AndersDJohnson/OpenAPI-Specification that referenced this pull request Apr 8, 2019
Clenup JS test. Resolve external $ref during tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants