Skip to content

Addressed metadata documentation cleanup from #589 #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 7, 2016
Merged

Conversation

fehguy
Copy link
Contributor

@fehguy fehguy commented Oct 7, 2016

@fehguy
Copy link
Contributor Author

fehguy commented Oct 7, 2016

Fixes #199, #377

@darrelmiller
Copy link
Member

In the OpenAPI object the hosts key is still present but in the example it is shown as servers. Do we have a preference?

Also the description of the Host Object seems to have got stuck in the middle of the description of the Info Object.

@DavidBiesack
Copy link
Contributor

I prefer servers over hosts. The example shows

servers:
-   url: https://development.gigantic-server.com/v1

and I think "server" (as in "API server" / "service") is a better term here than host, as host should refer to just the host name development.gigantic-server.com. I don't think we should create a new definition of host that is not compatible with the definition of host in a URL

@fehguy
Copy link
Contributor Author

fehguy commented Oct 7, 2016

@darrelmiller i will fix that.

@darrelmiller
Copy link
Member

Need to add a new doc that discusses migration guidelines and expectations from tooling vendors in regards to being compatible between minor versions.

The following shows how multiple hosts can be described in the host object array

```yaml
servers:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatives for servers: instances … ?

@fehguy
Copy link
Contributor Author

fehguy commented Oct 7, 2016

the terms hosts and servers need to be updated accordingly in the operations / paths objects

enum:
- https
- http
default: https
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default currently applies to optional parameters and represents the server-assumed default, like the number of results in a page or an offset. By applying it to a required element, we confuse an already tricky aspect of a spec. An alternative could be example.

servers:
- url: {scheme}://{host}:{port}/{basePath}
description: The production API server
templates:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, introducing templates when other path templates use parameters seems less elegant, but I don't have a better alternative to supply at this time.

@fehguy
Copy link
Contributor Author

fehguy commented Oct 7, 2016

@webron to add documentation about what happens when the servers attribute is empty or not present

@fehguy fehguy merged commit a8f6f6d into OpenAPI.next Oct 7, 2016
@fehguy fehguy deleted the issue-589 branch October 7, 2016 17:04
@webron webron mentioned this pull request Oct 7, 2016
5 tasks
AndersDJohnson pushed a commit to AndersDJohnson/OpenAPI-Specification that referenced this pull request Apr 8, 2019
Addressed metadata documentation cleanup from OAI#589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants