Skip to content

Changed the query language from JMESPath to JSONPath #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

darrelmiller
Copy link
Member

Updated the proposal to use JSONPath based on the current draft https://www.ietf.org/id/draft-ietf-jsonpath-base-04.html

JMESPath was originally selected because it had a specification and an extensive test suite. However, experimentation has shown that JMESPath is optimized to transforming the input JSON document into an output JSON document. The goal is to select and project. However, for Overlays, the objective is to select a set of elements in the target document. There is no need for the ability to project new JSON objects.

Since the original draft of the Overlay specification was created, there has been an effort in the IETF to standardize the JSONPath specification. The original JSONPath definition relied on scripting support from the underlying implementation. This would not be suitable for the Overlay specification. The new IETF version is taking efforts to make the JSONPath use a fully specified query expression that is not implementation dependent.

@ponelat
Copy link

ponelat commented May 24, 2022

Link to the general page of JSONPath so I can remember: https://tools.ietf.org/wg/jsonpath/

@darrelmiller darrelmiller requested a review from webron July 4, 2022 17:33
@darrelmiller darrelmiller requested a review from kevinswiber July 18, 2022 19:13
Copy link

@kevinswiber kevinswiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ponelat
Copy link

ponelat commented Jul 27, 2022

@webron can you approve/merge?

@lornajane
Copy link
Contributor

I'm looking at implementing something to do overlays; can I assume this will be merged? I think it should be, if that counts at all!

Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregsdennis
Copy link
Contributor

gregsdennis commented Sep 21, 2023

Uh... current draft is https://datatracker.ietf.org/doc/html/draft-ietf-jsonpath-base. It's on v20 now, which has some significant changes from v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants