-
Notifications
You must be signed in to change notification settings - Fork 6
Add clang format file #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Fixed an incorrect option name causing the formatting to not work - Increased column limit to 120 - Moved access modifiers back
this aligns more cloesly with the current codebase, and seems like a good idea since most of the code will be in the `GridKit` namespace
- Short functions will never be on a single line - Don't binpack arguments/parameters - Align pointers and references to the left
I've tested that this works with the current version of There is a new option added in (I believe) the latest version - version |
- Comments effectively have an extra 80 character column limit from the rest of code (bringing it up to 200 characters) - Comments which are not meant to be written/read in-editor (such as in-documentation Latex or Matlab code, meant to be rendered by other software or copied/pasted directly from/to other software) can start with ** to indicate that they should not be formatted in any way, and clang-format will skip those lines.
I believe I've fixed all outstanding concerns with column limits in comments. There are two new changes:
|
@pelesh I looked into the issue of putting system header includes before local includes. It turns out that
|
Closing in favor of #68. |
I added options in order of:
How they appear in the style guide
How they appear in the current code
If there are conflicts in the current code, then I picked the option I prefer
There currently isn't a formatting option for forcing a newline between includes and the rest of the file, however there is a pull request to add this feature, so it may exist in a future version.
Please see #32 for the current up to date formatting results of the file.