chromium: build ChromeDriver #34
Conversation
|
|
||
| FILES_${PN} = "${bindir}/${BPN} ${datadir}/applications ${sbindir}/ ${libdir}/${BPN}/" | ||
| FILES_${PN} += "${bindir} ${libdir}" | ||
| FILES_${PN} += "${bindir}/${BPN}/*.pak" | ||
| FILES_${PN} += "${bindir}/${BPN}/locales/*.pak" | ||
|
|
||
| FILES_${PN}-chromedriver-dbg += "${bindir}/${BPN}/.debug/chromedriver" |
|
By how much does this increase the build time of chromium? If it's a significant amount, it would be better if this were broken out so it is only built for those interested in it specifically. |
mrchapp
force-pushed
the
chromedriver-master
branch
from
f49f75b to
0f1c827
Compare
|
Or maybe a default-off PACKAGECONFIG? |
|
Agreed and also a way to disable it might be on package config as well. Be it enabled or not by default. |
This is a temporary bbappend so that ChromeDriver is included in our builds while this pull request is merged in upstream meta-browser: OSSystems/meta-browser#34 Signed-off-by: Daniel Díaz <[email protected]>
|
Everyone is welcome, of course, to do their own testing. In my testing I found no increase in overall build time. In fact the time to build with the patch went down by almost a minute. Of course I only did one build of each, but suffice to say it's not impacting build time in my one test at all :-) current master: Methodology:
MACHINE = "dragonboard-410c" |
|
@twoerner, fantastic! Lucky you -- my build only took 5 hours and 10 minutes. I added Would you guys still prefer to add another PACKAGECONFIG for this? Being a separate PACKAGE may suffice, but please advise. By the way, the .debug part for chromedriver has been fixed, as requested by @otavio, in the original branch (force-pushed, probably messed that one up.) |
|
Thanks for handling it. I think that adding a build option is worth the work, specially as it is straightforward. |
This patch enables the build of ChromeDriver. This comes in very handy for test automation. More information can be found here: https://sites.google.com/a/chromium.org/chromedriver/ Signed-off-by: Daniel Díaz <[email protected]>
mrchapp
force-pushed
the
chromedriver-master
branch
from
0f1c827 to
d8ca720
Compare
|
Branch refreshed. |
This is a temporary bbappend so that ChromeDriver is included in our builds while this pull request is merged in upstream meta-browser: OSSystems/meta-browser#34 Signed-off-by: Daniel Díaz <[email protected]>
This patch enables the build of ChromeDriver. This comes
in very handy for test automation. More information can
be found here:
https://sites.google.com/a/chromium.org/chromedriver/
Signed-off-by: Daniel Díaz [email protected]