chromium: update to 113.0.5672.126 #721
Conversation
|
Alright, this is finally ready. Sorry for taking a bit, I definitely need to improve my build testing setup 😅 This is a big update, but for the most part it's just backports. Most of the backported patches are to avoid C++20-specific features, which make especially dunfell's clang 12 very unhappy. Without the backports, it's just two new patches, one of which is very small and will hopefully be accepted upstream. |
|
@MaxIhlenfeldt, @rakuco, @rwmacleod Next started build with kirkstone branch for qemux86-64, qemuarm & qemuarm64. |
|
@MaxIhlenfeldt , @rakuco & @rwmacleod kirkstone branch machines:rpi4, qemux86-64 Build errors
@console-latest.log:
Building with dunfell branch meanwhile. |
...cipes-browser/chromium/files/0009-nomerge-attribute-on-declaration-is-only-available-s.patch
Show resolved
Hide resolved
|
Have built chromium for dunfell branch as well and it gives the similar errors.
Let me try adding this patch "[0009-nomerge-attribute-on-declaration-is-only-available-s.patch]" and build again. |
Have checked adding this patch again but, still getting the errors. |
|
These are only warnings, they shouldn't cause the build to fail. They're expected, see this patch's commit message. Can you grep for "error:" in the build log? |
|
@MaxIhlenfeldt , Today, I have built chromium for mickledore branch and getting the below errors:
|
Hm, |
Let me try this. |
@MaxIhlenfeldt , With these above changes in the patch, chromium has built successfully without any error for rpi4 & qemux86-64 in kirkstone branch so far and build is going on for other systems :-) I am quite surprised that why the error was not observed in master branch build. |
Interesting, thanks! I'll update the patch, then. I'll also try and upstream these additions.
master uses clang 16, right? I think that clang version doesn't need the patch at all, it's only needed for older versions of clang. |
Yes, master uses clang 16. |
|
Have built & tested the chromium for below systems in kirkstone branch and all worked fine.
Next is dunfell & mickledore branches. |
|
Have built & tested the chromium for below systems in dunfell branch and all worked fine except rpi4.
Have observed the below errors in rpi4: These above errors have been observed in some earlier releases and we have never solved it until upgrading, let's wait an see what 114 does for dunfell. Next build is going on for mickledore branch. |
|
As @nrpt-m mentioned, the network service crash is back on RPi4/dunfell (maybe it was there all along and no one was testing it?). I think we should note it as a limitation in the commit log and see if goes away in 114. |
|
@MaxIhlenfeldt @rakuco @rwmacleod
If you are agree with the above test results in all the branches then, please modify |
MaxIhlenfeldt
force-pushed
the
113.0.5672.126
branch
2 times, most recently
from
52a9dff to
76c1098
Compare
|
Thank you for all the testing! I've updated patch 0021, and also 0023 as it has been accepted upstream. I'm currently doing one final build to make sure I didn't mess up any of the patch changes. @nrpt-m can you please confirm I wrote down the correct machines for the master branch in the "Test-built" section? You explicitly listed them for the other branches (thanks a lot!), but I'm not sure which one you used for master. |
For master branch, we have tested the below systems:
|
Release notes:
https://chromereleases.googleblog.com/2023/05/stable-channel-update-for-desktop.html
https://chromereleases.googleblog.com/2023/05/stable-channel-update-for-desktop_8.html
https://chromereleases.googleblog.com/2023/05/stable-channel-update-for-desktop_16.html
Build and patch changes:
------------------------
Drop 0009-nomerge-attribute-on-declaration-is-only-available-s.patch as
all supported Yocto releases use clang >= 12 by now.
Drop 0013-Fix-html_minifier-script-for-node-v12.patch as all supported
Yocto releases use Node >= 14 by now.
Revert an upstream change that allows mixing `__attribute__` and
`alignas` syntax, because older versions of clang still used by some
Yocto releases don't like that very much.
Add 0021-Add-missing-typename-s.patch to fix a compile error.
Backport various patches to fix compile errors:
0019-Backport-constexpr-std-string-fixes.patch
0022-Backport-Avoid-capturing-structured-bindings.patch
0023-Backport-IWYU-for-translate-TranslateUILanguagesMana.patch
0024-Backport-Fix-erroneous-SupportsOstreamOperator-int-i.patch
0025-Backport-Do-not-use-std-monospace-for-absl-variant.patch
0026-Backport-std-string-ends_with-is-C-20.-Use-base-Ends.patch
Rebase remaining patches.
License changes:
----------------
Added licenses:
* chrome/browser/resources/chromeos/accessibility/chromevox/third_party/tamachiyomi/LICENSE
- https://chromium-review.googlesource.com/c/chromium/src/+/4296260
* third_party/cros-components/LICENSE
- https://chromium-review.googlesource.com/c/chromium/src/+/4295996
* third_party/libei/LICENSE
- https://chromium-review.googlesource.com/c/chromium/src/+/4221794
Removed licenses:
* third_party/android_rust_toolchain/toolchain/share/doc/rust/LICENSE-APACHE
- Not sure what change caused the removal, but I suppose something in
the third-party checkout logic changed so that this isn't checked
out for non-Android configurations.
Updated licenses:
* third_party/libjpeg_turbo/LICENSE.md
- https://chromium-review.googlesource.com/c/chromium/deps/libjpeg_turbo/+/3500634,
https://chromium-review.googlesource.com/c/chromium/deps/libjpeg_turbo/+/4219963
Test-built:
-----------
* chromium-ozone-wayland:
- master, clang, MACHINE=qemux86-64
- mickledore, clang, MACHINE=qemux86-64
- langdale, clang, MACHINE=qemuarm64
- kirkstone, clang, MACHINE=raspberrypi3, qemux86-64
- dunfell, clang**, MACHINE=qemux86-64
* chromium-x11
- master, clang, MACHINE=raspberrypi4-64, qemux86-64, qemuarm64, qemuarm
- mickledore, clang, MACHINE=raspberrypi4-64, qemux86-64, qemuarm64, qemuarm
- kirkstone, clang, MACHINE=raspberrypi4-64, qemux86-64, qemuarm64, qemuarm
- dunfell, clang**, MACHINE=raspberrypi3, raspberrypi4-64***, qemux86-64, qemuarm64, qemuarm
** Please note that Chromium requires below set-up when on dunfell
branch.
- The clang version to be >= 12 and for that, use the latest
meta-clang/dunfell-clang12 branch.
- Require the latest meta-oe with Nodejs 14.x support.
- Add the PREFERRED_VERSION_nodejs-native = "14.%" in conf/local.conf
file.
*** Please note that there currently is a problem on RPi4/dunfell where
Chromium's network service crashes.
Signed-off-by: Max Ihlenfeldt <[email protected]>
MaxIhlenfeldt
force-pushed
the
113.0.5672.126
branch
from
76c1098 to
df8e94d
Compare
|
Thanks! I've updated the commit message and the PR description. Let's merge this! |
Release notes:
https://chromereleases.googleblog.com/2023/05/stable-channel-update-for-desktop.html
https://chromereleases.googleblog.com/2023/05/stable-channel-update-for-desktop_8.html
https://chromereleases.googleblog.com/2023/05/stable-channel-update-for-desktop_16.html
Build and patch changes:
Drop 0009-nomerge-attribute-on-declaration-is-only-available-s.patch as all supported Yocto releases use clang >= 12 by now.
Drop 0013-Fix-html_minifier-script-for-node-v12.patch as all supported Yocto releases use Node >= 14 by now.
Revert an upstream change that allows mixing
__attribute__andalignassyntax, because older versions of clang still used by some Yocto releases don't like that very much.Add 0021-Add-missing-typename-s.patch to fix a compile error.
Backport various patches to fix compile errors:
0019-Backport-constexpr-std-string-fixes.patch
0022-Backport-Avoid-capturing-structured-bindings.patch
0023-Backport-IWYU-for-translate-TranslateUILanguagesMana.patch
0024-Backport-Fix-erroneous-SupportsOstreamOperator-int-i.patch
0025-Backport-Do-not-use-std-monospace-for-absl-variant.patch
0026-Backport-std-string-ends_with-is-C-20.-Use-base-Ends.patch
Rebase remaining patches.
License changes:
Added licenses:
Removed licenses:
Updated licenses:
Test-built:
** Please note that Chromium requires below set-up when on dunfell branch.
*** Please note that there currently is a problem on RPi4/dunfell where Chromium's network service crashes.
Signed-off-by: Max Ihlenfeldt [email protected]