Queued server actions #153
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I say "effective" because when somebody does a callControlled, the main server thread is blocked and their thread resumes, but it's as-if they were the server thread in terms of contention.
Things like hardware detect trigger on connection will get moved here so we don't spend as much time in our message handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when we get a new connection (or some other theoretical trigger for a hardware detect), we do it right then. This can cause weird things to happen, because it basically means our message handlers take a long time to complete. What we should be doing is instead setting a flag when a hardware detect is "triggered" and only actually doing that "between" mainloops.
This branch is work starting on it, almost done.