Don't call RegisterType twice for each RPC and with the redis queue it was 4 times! #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeButters
force-pushed
the
luke/perf-msg-serializer
branch
from
8c95dd0 to
296247c
Compare
LukeButters
changed the title
rhysparry
approved these changes
Sep 14, 2025
| AddProtocolTupesToTypeRegistry(this.typeRegistry); | ||
| } | ||
|
|
||
| public static void AddProtocolTupesToTypeRegistry(ITypeRegistry typeRegistry) |
There was a problem hiding this comment.
nit: should be AddProtocolTypesToTypeRegistry (i.e. Types not Tupes)
There was a problem hiding this comment.
🤦 sorry yes how did i miss that.
|
|
||
| public static void AddProtocolTupesToTypeRegistry(ITypeRegistry typeRegistry) | ||
| { | ||
| foreach (var protocolType in protocolTypes) typeRegistry.RegisterType(protocolType, protocolType.Name, true); |
There was a problem hiding this comment.
nit: if we're moving this anyway, let's format it with curly braces across multiple lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We would re-register the types each time the serializer was built, since that is built with this lambda each time we serialise or deserialize a message:
With these changes we just register the types once, rather than over and over again.
This as a hot spot was somehow found with a profiler.
With this change we instead call register once for the Request and Response types rather than each time we serialise or deserialise a message (including in and out of the queue). This should have no impact other than improving performance.
How to review this PR
Quality ✔️
Pre-requisites