Skip to content

Conversation

magicxyyz
Copy link
Contributor

Adds released flag to pebbleIterator to avoid double closing cockroachdb/pebble.Iterator as it is an invalid operation.

This PR backports: ethereum/go-ethereum#28566
Fixes: ethereum/go-ethereum#28565

Adds 'released' flag to pebbleIterator to avoid double closing cockroachdb/pebble.Iterator as it is an invalid operation.

Fixes #28565
@cla-bot cla-bot bot added the s CLA signed label Nov 21, 2023
@magicxyyz magicxyyz marked this pull request as ready for review November 22, 2023 01:46
Copy link
Contributor

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 0a65849 into master Nov 22, 2023
@PlasmaPower PlasmaPower deleted the backport-pebble-iterator-release branch November 22, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s CLA signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated call to pebbleIterator.Release accesses memory returned to sync.Pool
2 participants